Skip to content

Convert setup.py to declarative configuration setup.cfg file #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Feb 6, 2022

Refer to setuptools' declarative configuration page for moving the static metadata into setup.cfg.

A few other notes:

  • Use pyproject.toml for PEP 517 implementation, but keep setuptools as build backend for now
  • A universal wheel is now built for both Python 2 and 3 compatibility (using [bdist_wheel] universal=1; when py2 is eventually dropped, then remove that section)
  • Version is dynamically read from shapefile.py
  • Remove the various Python 3.x classifiers, and just use Python 3, as this is an unnecessary maintenance classifier as old packages should work fine with future Python versions (Python 2.7 is the sole exception); add a few other classifiers
  • Setuptools' author field is really designed to only hold one; move @karimbahgat as maintainer (same as README.md)
  • zip_safe was removed as it's not needed
  • Now setup.py is a simple wrapper, which some folks expect to see; it may go away someday

@karimbahgat karimbahgat merged commit 45fe4a7 into GeospatialPython:master Feb 23, 2022
@karimbahgat
Copy link
Collaborator

This looks great and thorough! Takes care of some nuisances i've had when publishing in the past, such as bumping the version in multiple places. It's good with some help in order to catch up with the latest publishing conventions, very much appreciated.

@karimbahgat
Copy link
Collaborator

Only thing, i see you removed sdist and wheel flags in the build command, does this mean they are on by default? Ie will this still create wheels?

@mwtoews mwtoews deleted the setup-cfg branch February 23, 2022 21:12
@mwtoews
Copy link
Contributor Author

mwtoews commented Feb 23, 2022

Yup, the default behavior (as described by the docs) are to build both sdist and wheel outputs, as confirmed by the last message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants